Skip to content

Conversation

@fmease
Copy link
Member

@fmease fmease commented Jan 25, 2026

Alternative to #151659.

Fixes #151548.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 25, 2026
@fmease fmease changed the title Bump std's' backtrace's rustc-demangle' Bump std's backtrace's rustc-demangle' Jan 25, 2026
@fmease fmease force-pushed the bump-backtrace-demangler-alt branch from 850c30f to 59c0e13 Compare January 25, 2026 23:09
@fmease
Copy link
Member Author

fmease commented Jan 25, 2026

@bors try

@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Jan 25, 2026
Bump `std`'s `backtrace`'s `rustc-demangle`'
@fmease fmease changed the title Bump std's backtrace's rustc-demangle' Bump std's backtrace's rustc-demangle Jan 25, 2026
@fmease fmease force-pushed the bump-backtrace-demangler-alt branch from 59c0e13 to f4731a1 Compare January 25, 2026 23:10
@fmease

This comment was marked as resolved.

@rust-bors

This comment was marked as resolved.

@fmease
Copy link
Member Author

fmease commented Jan 25, 2026

@bors try

@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Jan 25, 2026
Bump `std`'s `backtrace`'s `rustc-demangle`
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 26, 2026

☀️ Try build successful (CI)
Build commit: 240bbcc (240bbccbd0c2235c2ed39b1a7d307a56e8634097, parent: 873d4682c7d285540b8f28bfe637006cef8918a6)

@fmease fmease marked this pull request as ready for review January 26, 2026 11:33
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 26, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 26, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 26, 2026

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tgross35
Copy link
Contributor

Would it make sense to add a test for #151548 here?

@fmease
Copy link
Member Author

fmease commented Jan 28, 2026

Would it make sense to add a test for #151548 here?

We have a UI test for the mangling & demangling of assoc const bindings in the compiler (see). I sure could add a //@ run-crash test to tests/ui/panic/ if you want me to. I just thought it wasn't really worth it for such a niche feature. 🤷 Just let me know if you think otherwise :)

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, the chance of backsliding seems rather low and non-catastrophic.

@bors r+

View changes since this review

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 28, 2026

📌 Commit f4731a1 has been approved by tgross35

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2026
rust-bors bot pushed a commit that referenced this pull request Jan 28, 2026
…uwer

Rollup of 12 pull requests

Successful merges:

 - #150491 (resolve: Mark items under exported ambiguous imports as exported)
 - #150720 (Do not suggest `derive` if there is already an impl)
 - #150968 (compiler-builtins: Remove the no-f16-f128 feature)
 - #151493 ([RFC] rustc_parse: improve the error diagnostic for "missing let in let chain")
 - #151660 (Bump `std`'s `backtrace`'s `rustc-demangle`)
 - #151696 (Borrowck: Simplify SCC annotation computation, placeholder rewriting)
 - #151704 (Implement `set_output_kind` for Emscripten linker)
 - #151706 (Remove Fuchsia from target OS list in unix.rs for sleep)
 - #151769 (fix undefined behavior in VecDeque::splice)
 - #151779 (stdarch subtree update)
 - #151449 ([rustdoc] Add regression test for #151411)
 - #151773 (clean up checks for constant promotion of integer division/remainder operations)
@rust-bors rust-bors bot merged commit 1eba55e into rust-lang:main Jan 29, 2026
12 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 29, 2026
rust-timer added a commit that referenced this pull request Jan 29, 2026
Rollup merge of #151660 - fmease:bump-backtrace-demangler-alt, r=tgross35

Bump `std`'s `backtrace`'s `rustc-demangle`

Alternative to #151659.

Fixes #151548.
github-actions bot pushed a commit to rust-lang/compiler-builtins that referenced this pull request Jan 29, 2026
…uwer

Rollup of 12 pull requests

Successful merges:

 - rust-lang/rust#150491 (resolve: Mark items under exported ambiguous imports as exported)
 - rust-lang/rust#150720 (Do not suggest `derive` if there is already an impl)
 - rust-lang/rust#150968 (compiler-builtins: Remove the no-f16-f128 feature)
 - rust-lang/rust#151493 ([RFC] rustc_parse: improve the error diagnostic for "missing let in let chain")
 - rust-lang/rust#151660 (Bump `std`'s `backtrace`'s `rustc-demangle`)
 - rust-lang/rust#151696 (Borrowck: Simplify SCC annotation computation, placeholder rewriting)
 - rust-lang/rust#151704 (Implement `set_output_kind` for Emscripten linker)
 - rust-lang/rust#151706 (Remove Fuchsia from target OS list in unix.rs for sleep)
 - rust-lang/rust#151769 (fix undefined behavior in VecDeque::splice)
 - rust-lang/rust#151779 (stdarch subtree update)
 - rust-lang/rust#151449 ([rustdoc] Add regression test for rust-lang/rust#151411)
 - rust-lang/rust#151773 (clean up checks for constant promotion of integer division/remainder operations)
@fmease fmease deleted the bump-backtrace-demangler-alt branch January 29, 2026 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Symbol of items instantiated w/ dyn trait w/ assoc const bindings not demangled (aka backtrace's rustc-demangle needs to be bumped)

3 participants